Fix #1 - Implement refresh button event handler#2
Open
harshadsabne wants to merge 1 commit intocreativcoder:mainfrom
Open
Fix #1 - Implement refresh button event handler#2harshadsabne wants to merge 1 commit intocreativcoder:mainfrom
harshadsabne wants to merge 1 commit intocreativcoder:mainfrom
Conversation
|
|
||
| pub fn render_news_cards(&self, ui: &mut eframe::egui::Ui) { | ||
| if self.config.refresh_news_data{ | ||
| let default_loading_msg = NewsCardData { |
Owner
There was a problem hiding this comment.
We could do this, but this seems unnecessary. Reason: We're needlessly adding dummy data, only to render a loading state.
| pub struct HeadlinesConfig { | ||
| pub dark_mode: bool, | ||
| pub api_key: String, | ||
| pub refresh_news_data: bool, |
Owner
There was a problem hiding this comment.
This need not be part of HeadlinesConfig as it's a state that is applicable while the app is running.
| if self.config.refresh_news_data{ | ||
| self.config.refresh_news_data = false; | ||
| // tracing::error!("Refresh event triggered."); | ||
| let (mut news_tx, _news_rx) = channel(); |
Owner
There was a problem hiding this comment.
We're also creating a fresh channel pair in update method, which isn't ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.