schedule: added unified schedule config struct#333
schedule: added unified schedule config struct#333jkellerer merged 5 commits intocreativeprojects:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 69.96% 70.50% +0.54%
==========================================
Files 118 119 +1
Lines 11923 12176 +253
==========================================
+ Hits 8341 8584 +243
- Misses 3193 3196 +3
- Partials 389 396 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
39e0e32 to
9a46c4c
Compare
9a46c4c to
35f7b6a
Compare
|
@creativeprojects , think it is ready now. had it running on one of my machines and schedules work like before (had them recreated to use run-schedule). |
b4fda25 to
b850ecc
Compare
|
I looked at the MR and so far it all looks good to me. Oh BTW I forgot to mention I think we have no way of displaying a group configuration: the |
|
Thanks for checking! |
creativeprojects
left a comment
There was a problem hiding this comment.
It works fine 😛
Thank you for the great work 😉
I think we can merge it and I'll install it on more instances for good measure
|
Had already began refactoring #290 to allow scheduling groups. That is the only remaining part. |
Draft for schedule structs discussed in #80
.. and finally group support (in this PR, it is config only. Also needs updates to scheduling (partially done in #290), coming later):