syslog: local syslog and stdout redirection#344
syslog: local syslog and stdout redirection#344jkellerer merged 1 commit intocreativeprojects:masterfrom
Conversation
|
@creativeprojects , do you have any concerns with this. It does change previous behaviour in that it now sends command output by default (though #343 allows to control it). On the other hand the previous version was a bit inconsistent since we sent it to log files but not to syslog. |
|
Yeah I'm fine with it 👍🏻 |
1b19273 to
8c12867
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 70.90% 70.91% +0.01%
==========================================
Files 121 121
Lines 12299 12304 +5
==========================================
+ Hits 8720 8725 +5
Misses 3185 3185
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Marked it ready for a final review, manually tested all options. |
creativeprojects
left a comment
There was a problem hiding this comment.
Works fine, and makes more sense than the previous implementation 👍🏻
Thanks 😉
In relation to #343, this PR adds local syslog server and command output redirection into syslog.
Motivation: Currently I redirect systemd output to syslog (including all stdout/err from resticprofile). This PR allows to have the same support using the built-in syslog client, which has the advantage of more consistent timestamps (not duplicated in stdout formatted log).
The following additional log URLs are added:
syslog:(local syslog server via unix socket)syslog://hostname(udp on default port 514)syslog://hostname:514(udp on port 514)syslog-tcp://hostname(tcp on default port 514)syslog-tcp://hostname:514(tcp on port 514)