fix: Improve error message for invalid connection Id#1296
fix: Improve error message for invalid connection Id#1296CodeWithAryanK wants to merge 2 commits intocredebl:developfrom
Conversation
Signed-off-by: CodeWithAryanK <172922447+CodeWithAryanK@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @GHkrishna 👋 Just wanted to let you know that I’ve raised the PR for issue #1229 as discussed. Here’s the link to the PR: #1296 – fix: Improve error message for invalid connection Id Let me know if any changes are needed. Thanks again! 🙌 |
|
Thank you for the contribution @CodeWithAryanK Do you mind, having a look at the failing, signature verification: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
Co-authored-by: Krishna Waske <kish77na@gmail.com> Signed-off-by: Aryan <aryankumarbackup@gmail.com>
|
|
Looks fine to me, we can merge it. Just have a look at the failing DCO, you would need to run these two commands locally (as per the suggestion here): git rebase HEAD~2 --signoff
git push --force-with-lease origin fix-connection-id-error-message |
|
Hi @CodeWithAryanK can you please fix DCO issue so that we can merge this PR. |



This PR updates the error message shown when an invalid connection Id (e.g., a space) is provided.
Old: "Invalid format for connectionId"
New: "Please provide a valid connectionId"
This improves clarity and user guidance.