fix(Instagram): Resolve bytecode verifier crashes - #1600
Merged
Conversation
Collaborator
|
Is it possible to separate the profile action bar fix as a different commit as it's a different fix. If it's not possible no worries |
naoverse06
marked this pull request as draft
July 27, 2026 15:46
naoverse06
force-pushed
the
fix/insta-3.9.0-dev1
branch
from
July 27, 2026 17:06
696a4e6 to
5cf2a42
Compare
Collaborator
|
Good to merge ? |
naoverse06
marked this pull request as ready for review
July 27, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues occurring in instagram 439.0.0.37.89 patched with piko 3.9.0-dev.1. the inbox crash occurred because the action bar hook ran before
CHECK_CASTestablished the register as anIgdsActionBar, causing the verifier to reject aViewpassed as aViewGroup. the profile crash occurred because the friendship status patch skipped a required integer initialization, leaving a register typed as aStringwhere an integer was expected. moves the inbox hook after the required type conversion and preserves the integer initialization before bypassing the internal badge checks. restores the profile action bar hook after instagram's action bar builder and validates the target method, required fields, parameters, and registers before injection. the profile action bar dependency and settings fallback behavior are also restored.Testing
.\gradlew.bat :patches:check --rerun-tasks --console=plain.\gradlew.bat :patches:clean :patches:buildAndroid --console=plainCloses #1592 , #1601