Open
Conversation
added 2 commits
October 16, 2012 15:54
Event.js
Outdated
Member
There was a problem hiding this comment.
Это не читается. Много лишних скобочек и длинная строка.
if (typeof start === "number" &&
start / 20000000 > 0) {
// your stuff
}
Member
|
Код очень-очень разряжен коментами и поэтому дольше воспринимается. Фразы описывающие переменную слишком длинные "Переменная типа string, хранящая название города, в котором будет проходить событие." /**
* @name CoordinateStruct
*
* @field {String} city Город события
*/
...
/**
* @type {CoordinateStruct}
*/
coordinate : {
}
... |
Closed
added 2 commits
December 2, 2012 19:44
This reverts commit abcfbe0.
Author
|
Так верно? А то я запутался видимо. |
Member
|
Да. Вот так правильно. Я специально делаю, чтобы от каждого было по 1-му пулреквесту на домашку, а то потом можно запутаться. |
Author
|
Проблема именно с форматом документации? Пропущена строка между заголовком и описанием передаваемых параметров, и тому подобное? Или вся документация написана не верно? |
Member
|
Документация оформлена правильно относительно содержимого, но форматирование ее не совсем корректное. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.