Fix build errors and compiler warnings#1
Conversation
- Add KEY_STRAFE definition to doomkeys.h - Include z_zone.o in Makefile to resolve linker errors - Fix dangling pointer warning in r_things.c by making 'unsorted' static - Address snprintf truncation warnings in p_setup.c and wi_stuff.c - Fix type-related warnings in r_segs.c, i_input.c, and m_menu.c - Remove unused variables and mark unused static variables with __attribute__((unused)) - Update snprintf calls to use sizeof() where appropriate Co-authored-by: crishacks <234900867+crishacks@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
- Remove -Map linker flag from Makefile for macOS compatibility - Fix pointer-to-int cast warning in p_maputl.c using intptr_t - Remove unused totalwidth variable in r_data.c - Mark frac as unused in fuzz column functions in r_draw.c - Fix undeclared variable error for totalwidth in r_data.c Co-authored-by: crishacks <234900867+crishacks@users.noreply.github.com>
2 participants
This PR fixes the build error in iodoom_sdl.c and addresses several compiler warnings across the codebase to ensure a clean build and green CI. Key changes include adding missing definitions, updating the Makefile, and fixing potential memory safety issues with snprintf.
PR created automatically by Jules for task 16786432835747567234 started by @crishacks