Commented out second query method, changed orcid substring length, partial fix for shiny x-axis issue#35
Open
1catherinem wants to merge 5 commits intocrkn-rcdr:mainfrom
Open
Commented out second query method, changed orcid substring length, partial fix for shiny x-axis issue#351catherinem wants to merge 5 commits intocrkn-rcdr:mainfrom
1catherinem wants to merge 5 commits intocrkn-rcdr:mainfrom
Conversation
fixedrange=TRUE makes it so that the X-axis cannot be expanded past its defined range (I.e. go to -1), and so the user cannot pan/zoom to an undefined part of the range.
This will allow coauthors who are currently employed by another university and who have an Orcid account to have location data populated!
1catherinem
changed the title
I changed this so that if pull request crkn-rcdr#39 is merged into main, my pull request will not conflict.
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #33 . To maintain consistency within the file (line 289 has the second method commented out by default), maintain ease of use, and to prevent overriding of user data in my_query with the Temple University example data, I have commented out the second (complex) query method on line 191. This should make it so that a user can run the entire R script file once they've defined their organizational variables at the top and not get any errors as the script attempts to use data organization functions on an empty dataframe.
For issue #34 , added fixedrange=TRUE to the Plotly graph code in the Shiny app, this prevents the graph from showing or being moved anywhere outside its defined range, but Pull request #39 (Autorange=TRUE) is a better solution. I've updated the file in my pull request to reflect this better solution and to not cause any merge conflicts between these two solutions.
For issue #36 , in the code, Orcid co-author IDs were taken as a subset from a longer string. The length of this subset included a slash (/) at the beginning of the ID number, which prevented the Orcid IDs from being 'read' and generating location data in the output spreadsheet. I changed the the start point of the string subset from 18 characters in, to 19 characters in. This allows location data to be populated for co-authors currently employed at a university institution who have an Orcid account.