#10 Removed setwd() from networkscript#48
Open
epaul23 wants to merge 6 commits intocrkn-rcdr:mainfrom
Open
Conversation
crkn-rcdr#10 Network visualization working directory setup confusion has been fixed by removing hardcoded setwd() , since we are gonna be relying on relative path than absolute path
Removed setwd() calls and added a "Project setup" section to the README to encourage cloning/downloading the full repo and using relative paths (works in both RStudio and VS Code).
crkn-rcdr#11 :Headers added to improve clarity for Rorcid_Crossref_Authors.R and Rorcid_Crossref_Authors_Existing_List.R (This commit is my portion of a groupwork with Badri)
Followup on crkn-rcdr#11, Added License information on both files
Added unnest(title) for DataCIte's title, so it always returns "character" instead of list,, So that full_join() always work, and there wont be any Type mismatch errors in the future. The error was caused due to Datacite title returns as List and CrossRef as Character
crkn-rcdr#59 overwriting file name was fixed with file.rename() and adding the year it used for the run using paste0()
|
Great work. Thanks for making the changes across all the code files. The network script file is not used in this RProj, so it was deleted in #43. This issue has broader applicability though, so this is just a notification that CRKN will have to handle the merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10 Network visualization working directory setup confusion has been fixed by removing hardcoded setwd() , since we are gonna be relying on relative path than absolute path