Serialize chat-created model pricing as hashes#796
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 125 125
Lines 5872 5872
Branches 1460 1460
=======================================
Hits 5141 5141
Misses 731 731 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #784 by converting
Model::Infowrapper objects to plain hashes before persisting models created through chat model resolution. This keepsmodalitiesandpricingJSON columns in the same shape asacts_as_modelregistry sync.Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes
Tests
bundle exec rspec spec/ruby_llm/active_record/acts_as_model_spec.rbbundle exec rubocop lib/ruby_llm/active_record/chat_methods.rb spec/ruby_llm/active_record/acts_as_model_spec.rbbundle exec rspec spec/ruby_llm/active_record