Fix generator spec for use_new_acts_as default#801
Merged
Conversation
c7e93e2 made use_new_acts_as default to true and dropped the explicit line from the install template, but left the spec asserting it, breaking CI. Assert the line is absent instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 88.48% 88.47% -0.02%
==========================================
Files 122 122
Lines 5898 5898
Branches 1405 1405
==========================================
- Hits 5219 5218 -1
- Misses 679 680 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
c7e93e26("use_new_acts_as defaults to true") flipped theuse_new_acts_asconfig default totrueand removed the now-redundantconfig.use_new_acts_as = trueline from the install generator template. It updatedconfiguration_spec.rband the dummy initializer to match, but missedspec/ruby_llm/generators/install_generator_spec.rb, which still asserts the removed line is present.As a result CI has been red since
c7e93e26— the failure is only visible on commits that touchlib//spec/, so subsequent docs-only commits leftmain's status green while the suite was actually broken.This updates the assertion to expect the line is absent, matching the template and the new default (mirroring the existing
config.model_registry_classassertion just below it). The upgrade-to-v1.7 generator still emits the line, soupgrade_generators_spec.rbis left unchanged.Type of change
Scope check
Required for new features
N/A — bug fix.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name](N/A — spec-only change, no provider/HTTP code touched)bundle exec rspec spec/ruby_llm/generators/install_generator_spec.rb -e "creates initializer file"(the generator suite's live-API examples require provider keys and are unrelated to this change)models.json,aliases.json)API changes