You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(The new option as described in the readme doesn't work, but to me other options like indentationCharacter also have issues. The auto detection does work however.)
The toString() formatting only seems to work for some options and only after a .reset() which removes comments. For example indentationCharacter seems already broken, so it is not just the one I added.
The toString() formatting only seems to work for some options and only after a reset() which removes comments. For example indentationCharacter seems already broken, so it is not just the one I added.
That is the intended behavior. It keeps the current formatting unless you reset or introduce something the parser has not seen before, for example adding a new entry with an array when the current JSON has no array entries.
I've pushed a few suggestions. The most significant one is renaming the option to lineEnding, since "character" is not accurate here: CRLF is a sequence of two characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds logic to differentiate between CRLF and LF
(The new option as described in the readme doesn't work, but to me other options like
indentationCharacteralso have issues. The auto detection does work however.)Checklist