normalize base font size to $global-font-size on all screens#46
Open
normalize base font size to $global-font-size on all screens#46
Conversation
Member
|
What's the purpose of this change? It is a big change |
Member
Author
|
I'm guessing a downscaled font size was set from a desire to fit more on the screen on smaller viewports, but at the same time mobile users need larger tap/touch targets, not smaller. Better to make a design responsive by rearranging items on the screen or omitting them. And for a set of reusable components, forcing a smaller font size like this feels a little too opinionated to be at the package level, and is better set (if needed) by the using project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes font-size shrink to 87.5% for
smscreens.this preference should be set within the using project if desired