Skip to content

πŸ›‘οΈ Sentinel: Fix insecure socket creation in shared directories#100

Open
minibota wants to merge 1 commit intomainfrom
security/nightly-2025-01-05-11022395506798640199
Open

πŸ›‘οΈ Sentinel: Fix insecure socket creation in shared directories#100
minibota wants to merge 1 commit intomainfrom
security/nightly-2025-01-05-11022395506798640199

Conversation

@minibota
Copy link
Copy Markdown
Contributor

@minibota minibota commented Feb 2, 2026

πŸ” Issue: The daemon created the Unix socket file directly in /tmp (e.g., /tmp/cc-agent-user.sock) when XDG_RUNTIME_DIR was missing. This location is shared and sticky, allowing local attackers to pre-create the file to cause Denial of Service (DoS) or exploit race conditions.

🧠 Risk: A local attacker could prevent the agent from starting or potentially intercept connections if race conditions are exploited.

πŸ› οΈ Fix:

  • Created ensureSocketDir to enforce 0700 permissions and ownership on the socket directory.
  • Updated getSocketPath to use a dedicated subdirectory based on Effective UID: /tmp/cc-agent-<euid>/cc-agent.sock.
  • Daemon now creates this directory securely before listening.

πŸ§ͺ Tests:

  • Added TestEnsureSocketDir to verify directory creation, permission checks (0700), and rejection of insecure permissions.
  • Added TestGetSocketPath_Structure to verify path generation logic.
  • Ran all existing tests to ensure no regressions.

πŸ“Ž Notes: This change is transparent to users but changes the default socket location on systems without XDG_RUNTIME_DIR. exec command automatically resolves the new path.

This PR was created by an automated nightly security task.


PR created automatically by Jules for task 11022395506798640199 started by @minibota

Co-authored-by: minibota <1483356+minibota@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant