Skip to content

🛡️ Sentinel: Secure socket directory creation to prevent pre-creation and symlink attacks#106

Open
minibota wants to merge 1 commit intomainfrom
security/nightly-2026-02-05-12974733664033318369
Open

🛡️ Sentinel: Secure socket directory creation to prevent pre-creation and symlink attacks#106
minibota wants to merge 1 commit intomainfrom
security/nightly-2026-02-05-12974733664033318369

Conversation

@minibota
Copy link
Copy Markdown
Contributor

@minibota minibota commented Feb 5, 2026

🔐 Issue: The daemon created the Unix socket in a shared /tmp directory (fallback) with a predictable name, allowing local attackers to pre-create the socket (DoS) or potentially hijack connections. The original fix attempt introduced a TOCTOU race condition.

🧠 Risk: A local attacker could prevent the agent from starting or potentially intercept execution reports.

🛠️ Fix:

  • Changed socket path to use a private subdirectory based on EUID: /tmp/cc-agent-<euid>/cc-agent.sock.
  • Implemented ensureSocketDir with robust security checks:
    • Unconditional MkdirAll to minimize TOCTOU window.
    • os.Lstat to detect symlinks.
    • verifySocketDirOwnership to ensure directory is owned by the current user (preventing "confused deputy").
    • Strict 0700 permission enforcement.

🧪 Tests:

  • Added TestGetSocketPath_SecureFallback to verify path structure.
  • Added TestEnsureSocketDir to verify permission enforcement.
  • Added TestEnsureSocketDir_SymlinkAttack to verify symlink rejection.
  • Verified existing tests pass.

This PR was created by an automated nightly security task.


PR created automatically by Jules for task 12974733664033318369 started by @minibota

…attacks

Co-authored-by: minibota <1483356+minibota@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant