🛡️ Sentinel: Enforce concurrent connection limit on daemon socket#84
🛡️ Sentinel: Enforce concurrent connection limit on daemon socket#84google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
Fixed unbounded concurrency DoS vulnerability by implementing a semaphore to limit active socket connections. Added regression test `TestConcurrentConnectionLimit`. Hardened `cmd/daemon.go` with `maxConcurrentConnections`. Verified that excessive connections are blocked correctly.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🔐 Issue: The daemon's socket listener (
startSocketListener) spawned a new goroutine for every incoming connection without limit. A local attacker or runaway process could flood the socket, causing the daemon to exhaust system resources (goroutines, memory) and crash (DoS).🧠 Risk: High. Local users (or compromised services) could crash the core agent, preventing cron job execution and reporting.
🛠️ Fix: Implemented a semaphore pattern (buffered channel) to strictly limit the number of concurrent active connections to 50.
maxConcurrentConnectionsconstant.🧪 Tests:
cmd/security_concurrency_test.gowithTestConcurrentConnectionLimit.go test ./...).This PR was created by an automated nightly security task.
PR created automatically by Jules for task 7877803065727422335 started by @minibota