🛡️ Sentinel: Limit concurrent socket connections to prevent DoS#85
🛡️ Sentinel: Limit concurrent socket connections to prevent DoS#85google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
Limits the number of active socket connections to 50 using a semaphore. This prevents resource exhaustion (DoS) attacks where an attacker opens thousands of connections to the daemon. - Adds `maxConcurrentConnections` constant (default 50) - Adds semaphore logic to `startSocketListener` - Adds regression test `TestConcurrentConnectionLimit` Signed-off-by: Sentinel <sentinel@croncommander.dev>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🔐 Issue: The daemon's socket listener (
startSocketListener) spawned a new goroutine for every incoming connection without limit. A local attacker could exhaust system resources (memory, file descriptors) by opening thousands of connections, potentially crashing the agent.🧠 Risk: Denial of Service (DoS) via Resource Exhaustion. High impact (agent crash), Low complexity (trivial to exploit if local access is available).
🛠️ Fix: Implemented a semaphore (buffered channel) to strictly limit the number of concurrent socket handlers to 50. Excess connections will now block at the OS socket backlog level until a slot becomes available, providing effective backpressure.
🧪 Tests: Added
cmd/security_concurrency_test.gowhich:This PR was created by an automated nightly security task.
PR created automatically by Jules for task 15113937023558168799 started by @minibota