π‘οΈ Sentinel: Limit concurrent socket connections to prevent DoS#97
π‘οΈ Sentinel: Limit concurrent socket connections to prevent DoS#97
Conversation
Co-authored-by: minibota <1483356+minibota@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π Issue: The daemon's socket listener (
Acceptloop) spawned a new goroutine for every incoming connection without any concurrency limit. This allowed a local attacker (or malfunctioning client) to flood the daemon with connections, leading to unbounded goroutine creation and potential resource exhaustion (DoS).π§ Risk: High. A simple loop of
net.Dialcould cause the daemon to consume all available memory or thrash the scheduler, crashing the security agent and stopping cron job synchronization/reporting.π οΈ Fix:
maxConcurrentConnectionslimit (default: 100) using a semaphore pattern (buffered channel).Acceptloop now blocks when the limit is reached, creating backpressure on the OS socket backlog.π§ͺ Tests:
cmd/security_concurrency_test.go:TestBoundedConcurrency.maxConcurrentConnectionsis set to 5 and 20 clients connect, the number of active goroutines remains bounded (baseline + limit).π Notes: The default limit of 100 is conservative but sufficient for this agent's purpose (reporting job execution).
This PR was created by an automated nightly security task.
PR created automatically by Jules for task 6996260778888758772 started by @minibota