Skip to content

πŸ›‘οΈ Sentinel: Limit concurrent socket connections to prevent DoS#97

Open
minibota wants to merge 1 commit intomainfrom
security/nightly-2026-02-01-6996260778888758772
Open

πŸ›‘οΈ Sentinel: Limit concurrent socket connections to prevent DoS#97
minibota wants to merge 1 commit intomainfrom
security/nightly-2026-02-01-6996260778888758772

Conversation

@minibota
Copy link
Copy Markdown
Contributor

@minibota minibota commented Feb 1, 2026

πŸ” Issue: The daemon's socket listener (Accept loop) spawned a new goroutine for every incoming connection without any concurrency limit. This allowed a local attacker (or malfunctioning client) to flood the daemon with connections, leading to unbounded goroutine creation and potential resource exhaustion (DoS).

🧠 Risk: High. A simple loop of net.Dial could cause the daemon to consume all available memory or thrash the scheduler, crashing the security agent and stopping cron job synchronization/reporting.

πŸ› οΈ Fix:

  • Introduced a maxConcurrentConnections limit (default: 100) using a semaphore pattern (buffered channel).
  • The Accept loop now blocks when the limit is reached, creating backpressure on the OS socket backlog.
  • Added a check for "use of closed network connection" error to suppress logs during graceful shutdown.

πŸ§ͺ Tests:

  • Added cmd/security_concurrency_test.go: TestBoundedConcurrency.
  • This test verifies that even when maxConcurrentConnections is set to 5 and 20 clients connect, the number of active goroutines remains bounded (baseline + limit).
  • Verified that the test fails without the fix and passes with it.
  • Ran all existing tests to ensure no regressions.

πŸ“Ž Notes: The default limit of 100 is conservative but sufficient for this agent's purpose (reporting job execution).

This PR was created by an automated nightly security task.


PR created automatically by Jules for task 6996260778888758772 started by @minibota

Co-authored-by: minibota <1483356+minibota@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant