Catch URI parse errors during routing#114
Closed
vendethiel wants to merge 2 commits intocroservices:mainfrom
Closed
Catch URI parse errors during routing#114vendethiel wants to merge 2 commits intocroservices:mainfrom
vendethiel wants to merge 2 commits intocroservices:mainfrom
Conversation
Member
Author
|
Travis says:
|
Member
Author
|
Not sure anymore. |
jnthn
reviewed
Oct 6, 2020
lib/Cro/HTTP/Router.pm6
Outdated
| my $routing-outcome = Cro::HTTP::LogTimeline::Route.log: $log-timeline-task, -> { | ||
| CATCH { | ||
| when X::Cro::Uri::ParseError { | ||
| emit Cro::HTTP::Response.new(:500status, :$request); |
Member
There was a problem hiding this comment.
I think it should be 400 (Bad Request), since it's the client's fault.
Member
|
The failure is this:
I wonder where we've ended up with that being called. |
Member
|
The problem being that 2019.03 is pre-rename, so has no |
Member
Author
No idea :). |
FCO
pushed a commit
to FCO/cro-http
that referenced
this pull request
Oct 1, 2025
FCO
pushed a commit
to FCO/cro-http
that referenced
this pull request
Oct 1, 2025
Contributor
|
Closing in favor of #209 which is a copy of this one |
FCO
pushed a commit
to FCO/cro-http
that referenced
this pull request
Oct 1, 2025
japhb
added a commit
that referenced
this pull request
Oct 2, 2025
Catch URI parse errors during routing (Copy from #114 vendethiel++)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is the best way to go about this, but...