Conversation
This has a specific meaning that may not be intended see croservices#193 https://medium.com/coderscorner/http-2-flow-control-77e54f7fd518 WINDOW_UPDATE frame with a value 0 results in a stream error of type protocol error.
|
this PR is fine - normally I would be happy to merge to main (my personal workflow) and then the change will flow into the next are you happy we work like this? |
|
@bduggan Oh wow! That's a really good find! Thank you! |
@librasteve I'm not understanding. What would be the alternative to merging to main and then doing a release? (I've never used mi6, but I guess it's no different from doing a release "manually".) |
|
@patrickbkr - oh my bad I looked at the Changes file and this pattern has always been a mark of mi6 ... but this distro is missing some other mi6 aspects (dist.ini...) which I missed My working model for the release process is now:
OK? |
My memory slowly comes back to me. There is an automated release process for cro. It's nicely documented in this README file.
That's fine. Feel very free to merge. |
|
now merging and close this |
|
On July 13, 2025 12:38:41 PM GMT+02:00, librasteve ***@***.***> wrote:
librasteve left a comment (croservices/cro-http#204)
now merging and close this
happy to try a point release going forward but too busy to learn first time this week
Cool! I'll do a release Soon™.
|
|
@bduggan @librasteve The release is now done. Thanks guys! |
|
Great! Thanks! |
Avoid sending a window update frame with 0 bytes.
I think this is the cause of the issue in #203 introduced by #193
quoting https://medium.com/coderscorner/http-2-flow-control-77e54f7fd518
"WINDOW_UPDATE frame with a value 0 results in a stream error of type protocol error."
fixes #203