fix: propagate env vars with shell: cap.sh {0}

[iamazeem]

Fixes #145.

Introduced --env-vars to propagate specific env vars like this:

shell: cpa.sh {0} --env-vars "VAR_1 VAR_2 MY_VAR_* VAR_*_TEST_*"

Signed-off-by: Azeem Sajid azeem.sajid@gmail.com

[manxorist]

I do not like this approach at all.

Blindly exporting all environment variables that are set on the runner to the vm seems very wrong to me. Most of them are specific to the runner environment (hence the name, duh!) and either meaningless or outright wrong in the vm.

[jacob-carlborg]

Yes, for the reasons mentioned by manxorist the action is not already doing this.

[iamazeem]

@manxorist, @jacob-carlborg
Given the #145 (comment), this here is just an initial PoC to demonstrate that it's possible.

Definitely, exporting everything would break things e.g. PATH, TERM, etc.

How about a flag though e.g. --env-vars?

shell: cpa.sh {0} --env-vars "VAR_1 VAR_2 MY_VAR_* VAR_*_TEST_*"

[jacob-carlborg]

A flag seems reasonable. But there's no reason to start using Python. Another dependency, starting another process, which is slower than running inside the already started Node process.

[iamazeem]

A flag seems reasonable. But there's no reason to start using Python. Another dependency, starting another process, which is slower than running inside the already started Node process.

Please feel free to update this or maybe close this in favor of an alternative implementation as you've a better understanding of all the internals and the related performance overheads.

[jacob-carlborg]

This has been implemented in bbc9473.