fix(disposablerequest): prevent stuck external-create-pending#177
Open
davidferlay wants to merge 1 commit into
Open
fix(disposablerequest): prevent stuck external-create-pending#177davidferlay wants to merge 1 commit into
davidferlay wants to merge 1 commit into
Conversation
Signed-off-by: davidferlay <davidferlay.life@gmail.com>
3b2c302 to
d64aad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
DisposableRequest gets stuck in
external-create-pendingafter recreation or failed Create calls.The crossplane-runtime creation guard hard-stops reconciliation because the controller does not declare its external name as deterministic.
Fix:
managed.WithDeterministicExternalName(true)to both cluster-scoped and namespaced DisposableRequest reconcilersFixes #176
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
ResourceNotSyncedWithCreatePending: verifies Observe returnsResourceExists: falsewhenSynced=falseeven withexternal-create-pendingannotation set