feat: Add crossplane_managed_resource_* state metrics#308
Open
lkiii wants to merge 6 commits intocrossplane-contrib:masterfrom
Open
feat: Add crossplane_managed_resource_* state metrics#308lkiii wants to merge 6 commits intocrossplane-contrib:masterfrom
lkiii wants to merge 6 commits intocrossplane-contrib:masterfrom
Conversation
Add Prometheus state metrics for all managed resource types following the Crossplane contribution guide for provider observability. Metrics exposed: - crossplane_managed_resource_exists - crossplane_managed_resource_ready - crossplane_managed_resource_synced Each metric is labeled with GVK. Polls every 30 seconds. Signed-off-by: Lukas Ignatavičius <lukas@cashcoach.ai>
chlunde
requested changes
Mar 3, 2026
Collaborator
chlunde
left a comment
chlunde
left a comment
There was a problem hiding this comment.
Could you look at provider-kubernetes and do setup automatic per-controller via MetricOptions? Poll interval should be a CLI option - same as provider-kubernetes
We should avoid having to list each resource in a separate file here
Author
I have refactored the approach to be closer to provider-kubernetes |
lkiii
force-pushed
the
add-state-metrics
branch
3 times, most recently
from
aca79fa to
5a551ea
Compare
Replace the centralized SetupStateMetrics function and its explicit resource type list with per-controller registration, matching the pattern used in provider-kubernetes. - Add --poll-state-metric CLI flag (default 5s) instead of hardcoding - Build MetricOptions and pass it through controller.Options so each controller's Setup registers its own MRStateRecorder automatically - Add --metrics-bind-address flag to allow configuring the metrics port - Delete pkg/controller/statemetrics.go (centralized list no longer needed) - Keep Prometheus plumbing tests in metrics_test.go; drop config-list tests As a side effect, DefaultPrivileges is now correctly covered — it was missing from the old centralized list. Signed-off-by: Lukas Ignatavičius <lukas@cashcoach.ai>
Signed-off-by: Lukas Ignatavičius <lukas@cashcoach.ai>
Signed-off-by: Lukas Ignatavičius <lukas@cashcoach.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add Prometheus state metrics for all managed resource types following the Crossplane observability guide.
Metrics exposed:
crossplane_managed_resource_exists- Count of existing managed resourcescrossplane_managed_resource_ready- Count of ready managed resourcescrossplane_managed_resource_synced- Count of synced managed resourcesEach metric is labeled with GVK (GroupVersionKind). Polls every 30 seconds.
Implementation:
pkg/controller/statemetrics.gowithSetupStateMetrics()functionMRStateRecorderfor all 22 managed resource types (PostgreSQL, MySQL, MSSQL - both cluster and namespaced)pkg/controller/statemetrics_test.goFixes #307
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make reviewable):8080/metricscrossplane_managed_resource_existsincremented from 0 to 1 after the 30-second poll interval