chore: replace archived denisenkom/go-mssqldb with microsoft/go-mssqldb#326
Open
chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
Open
chore: replace archived denisenkom/go-mssqldb with microsoft/go-mssqldb#326chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
chlunde wants to merge 1 commit intocrossplane-contrib:masterfrom
Conversation
chlunde
force-pushed
the
upgrade-mssqldb
branch
from
c763606 to
2a56196
Compare
Collaborator
Author
|
@baburciu what do you think? The old driver didn't look maintained |
chlunde
force-pushed
the
upgrade-mssqldb
branch
from
2a56196 to
5b8f981
Compare
The denisenkom/go-mssqldb repository is archived. Migrate to the maintained Microsoft fork which is a drop-in replacement. Also update to go 1.26 as the new go-mssqldb pulls in a new Go version Fixes crossplane-contrib#315 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
Contributor
|
I'll build and test this against Azure SQL tomorrow |
Collaborator
Author
|
After updating to the latest version we got a Go version bump, so lets merge this one after Go 1.26 #323 as it will conflict anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The denisenkom/go-mssqldb repository is archived. Migrate to the
maintained Microsoft fork which is a drop-in replacement.
Fixes #315
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
e2e