Skip to content

Revert "[feat]: Surface deletionTimestamp as a printcolumn"#708

Merged
erhancagirici merged 1 commit into
mainfrom
revert-514-main
Jul 16, 2026
Merged

Revert "[feat]: Surface deletionTimestamp as a printcolumn"#708
erhancagirici merged 1 commit into
mainfrom
revert-514-main

Conversation

@jonasz-lasut

Copy link
Copy Markdown
Collaborator

Reverts #514

Objections raised:

  • Being-deleted is a rare state in a resource's lifecycle; the info is already obtainable via kubectl with extra flags; most Kubernetes resources don't surface this at all; there's no defined policy for what qualifies as a print column, which risks scope creep ("what about other fields people ask for?"). Not strongly opposed, but flags the implications.
  • The approach only works for upjet-based providers' MRs, not CRs generally, and printing a deletion
    column isn't a common CR convention.
  • The Ready condition already sets reason: Deleting when a resource is being deleted. They currently print the
    Ready status (True/False) but not the reason, the Ready condition/reason is a better lifecycle signal than a dedicated column.

Long term proposal is to introduce crd_types template similarly as with controller and setup templates

Signed-off-by: Jonasz Łasut-Balcerzak <jonasz@upbound.io>
@erhancagirici
erhancagirici merged commit 5e807d5 into main Jul 16, 2026
14 of 15 checks passed
@jonasz-lasut
jonasz-lasut deleted the revert-514-main branch July 16, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants