feat(config): add SkipWebhookCheck flag#60
Merged
sergenyalcin merged 1 commit intocrossplane:mainfrom Feb 24, 2026
Merged
Conversation
kaessert
force-pushed
the
feat/skip-webhook-check
branch
from
feb2f61 to
70b96ab
Compare
…th checks Add a SkipWebhookCheck option that allows consumers to disable the curl-based webhook endpoint health check (check_endpoints.sh) that runs before applying and importing resources. This is useful for consumers like up-cli that already ensure provider health before uptest runs, avoiding unnecessary external HTTP requests to raw.githubusercontent.com. The flag is plumbed through AutomatedTest, TestCase, the Builder, CLI flags, and template conditionals, following the existing SkipUpdate/SkipImport pattern. In the import template, patch.sh and patch-ns.sh downloads are kept outside the conditional since they are needed for the import step regardless of webhook checking. Also fixes a pre-existing copy-paste typo in tester.go where the SkipUpdate log message incorrectly referenced "skip-delete". Signed-off-by: Tobias Kässer <tobias.kasser@upbound.io>
kaessert
force-pushed
the
feat/skip-webhook-check
branch
from
70b96ab to
de76060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Consumers like up-cli already ensure provider health via kube.InstallConfiguration before uptest runs. The check_endpoints.sh curl to raw.githubusercontent.com is unnecessary in that context and introduces an external network dependency that can fail in restricted environments.
Test plan