feat: make pcre2 an optional cargo feature with docs#6
Open
biswapanda wants to merge 1 commit intocrusoecloud:mainfrom
Open
feat: make pcre2 an optional cargo feature with docs#6biswapanda wants to merge 1 commit intocrusoecloud:mainfrom
biswapanda wants to merge 1 commit intocrusoecloud:mainfrom
Conversation
Add [features] section to Cargo.toml with pcre2 as a default feature. Gate all pcre2-related code in split.rs behind #[cfg(feature = pcre2)] so consumers can opt out with default-features = false. Add feature-gated tests for both pcre2-on and fallback paths. Document the feature flag in README.md and add CONTRIBUTING.md with build/test instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add [features] section to Cargo.toml with pcre2 as an optinal and default feature.
Gate all pcre2-related code in split.rs behind
#[cfg(feature = pcre2)]so consumers can opt out withdefault-features = false.Add feature-gated tests for both pcre2-on and fallback paths.
Document the feature flag in README.md and add CONTRIBUTING.md with build/test instructions.
Related Dynamo CI failure - https://github.com/ai-dynamo/dynamo/actions/runs/23101799392/job/67103786703
This will allow disabling strict pcre2 (
libpcre2-dev) dependency -