Open
Conversation
adnan-kamili
approved these changes
Jan 14, 2026
There was a problem hiding this comment.
Pull request overview
This pull request adds a new FFI function binding for MigrateToSystemWideActivation to the LexActivator Ruby module, enabling migration of activations to system-wide scope.
Changes:
- Added
MigrateToSystemWideActivationfunction binding with proper FFI signature and documentation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+600
to
+601
| # @method MigrateToSystemWideActivation(oldPermissionFlag) | ||
| # @param [Integer] oldPermissionFlag |
There was a problem hiding this comment.
The parameter name "oldPermissionFlag" uses camelCase, which is inconsistent with the naming convention used throughout this file. Other functions use snake_case for parameter names (e.g., "file_path", "license_key", "app_version", "trial_extension_length"). Consider renaming to "old_permission_flag" for consistency.
Suggested change
| # @method MigrateToSystemWideActivation(oldPermissionFlag) | |
| # @param [Integer] oldPermissionFlag | |
| # @method MigrateToSystemWideActivation(old_permission_flag) | |
| # @param [Integer] old_permission_flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.