test: metamask bot#4
Open
cryptodev-2s wants to merge 7 commits intomainfrom
Open
Conversation
Feature/add attribution workflow
Owner
Author
|
@metamaskbot update-attributions |
7 tasks
|
Attributions updated |
cryptodev-2s
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Jun 5, 2024
## **Description** This pull request introduces a GitHub Action workflow dedicated to managing attributions effectively within our project. The key components of this new workflow include: - Local Scripts for Attributions Management: - `yarn build:attribution`: Updates attributions to reflect current dependencies. - `yarn test:attribution-check`: Checks if attributions are up-to-date with the latest changes. - GitHub Actions: - A check to ensure attributions are up-to-date on all pull requests. - An action that allows team members to update attributions directly by commenting `@metamskbot update-attributions` on any PR. ## **Related issues** Fixes: [#1550](MetaMask/mobile-planning#1550) ## **Manual testing steps** ### ***Locally*** - Run `yarn build:attribution` to update the attributions file. - Run `yarn test:attribution-check` to ensure all attributions are current. - ### ***On GitHub (CI/PR)*** - Open and push changes to a PR. - Intentionally remove an entry from attribution.txt to simulate an error. - Observe that CI fails due to missing attributions. - Comment `@metmaskbot update-attributions` on the PR. - A bot will respond with a thumbs up, followed by a comment indicating whether the attributions were successfully updated. For a practical demonstration, refer to the pull request in my fork: [PR Demonstration](cryptodev-2s#4) ### ***Note*** This functionality is currently operational only on a fork as it depends on the integration of the bot action into the develop branch. ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist