data/bypassing-stack-protector: Fix canary overwrite#208
Open
XXMA16 wants to merge 1 commit into
Open
Conversation
XXMA16
force-pushed
the
lab-4-stack-protector-bypass-fix
branch
2 times, most recently
from
50ed10d to
0f696ed
Compare
Solution now suggests overwriting the canary of the current stack frame instead of 2 up Signed-off-by: Mihnea Gheorghe <mihnea.gheorghe1610@stud.acs.upb.ro>
XXMA16
force-pushed
the
lab-4-stack-protector-bypass-fix
branch
from
0f696ed to
38f3573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
The canary and return address overwrites were done two frames higher (instead of only one).
An explicit statement that the canary overwrite should be commented out before proceeding with replacing the return address with
&pawnedhas also been added.Explanation
addrpoints to[RBP-16], since at[RBP-8]resides the canary, meaning thataddr[1]will overwrite it. The return address is found two machine words higher than that, at[RBP+8]