Update AbstractFlashcardViewer.java#1
Open
Georgezxh wants to merge 1 commit intocs304-spring2021:masterfrom
Open
Update AbstractFlashcardViewer.java#1Georgezxh wants to merge 1 commit intocs304-spring2021:masterfrom
Georgezxh wants to merge 1 commit intocs304-spring2021:masterfrom
Conversation
fix the issue#5648
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the issue#5648
Purpose / Description
problem: In nightmode, when entering contents like "color:white" in front or back fields, then we review the flashcard we will find the card reads "color: #000000". The color name after "color:" is replaced by the format of 0x......
Approach
The problem is that the current color inversion system tries to match a regex to the whole card content. The regex searches for css attributes like color: ... and background: .... so the contents in card will be searched successfully.
The old code calls this regex in nightmode, so I cancelled this call, and the bug disappeared.
How Has This Been Tested?
Reproduction Steps:
1.Enter "color: red" in front or back fields
2.Preview the flashcard
Then we will find the card reads "color:red",which is correctly