Skip to content

feature: change octave with Z and X#434

Merged
hlolli merged 1 commit intocsound:developfrom
Nandos0804:change-octave
Mar 21, 2026
Merged

feature: change octave with Z and X#434
hlolli merged 1 commit intocsound:developfrom
Nandos0804:change-octave

Conversation

@Nandos0804
Copy link
Contributor

This pull request adds to the Virtual Keyboard component keyboard shortcuts for octave shifting and improving the user interface to display the current octave range. Issue #71

@hlolli
Copy link
Member

hlolli commented Mar 21, 2026

very nice, look forward testing this

@hlolli hlolli merged commit c6e1928 into csound:develop Mar 21, 2026
2 checks passed
@Nandos0804
Copy link
Contributor Author

very nice, look forward testing this

We should consider, as a follow up, usability on mobile. I would look on how garage band and similar app present virtual keyboard on mobile screen. At this time is not user friendly.

I didn't want to address it now to avoid slowdowns or large PR to review

@vlazzarini
Copy link
Member

@Nandos0804 these developments are very welcome. Thanks a lot.

I just tested the ide on iOS Safari and now I can edit the code (before it was hard). One thing I noticed is that above the keyboard there is a search bar, which I had not seen before. It's a bit in the way, not sure if it can be removed.

@Nandos0804
Copy link
Contributor Author

@vlazzarini I'm really happy to help and give back to the community.

Related to the bug you reported, i tested on main and i'm not sure if I understood it properly(using chrome device emulation). If possible can i ask you to help me visualize the error?


nit: I discovered that we have 2 different top menu mobile rendering for the same page layout, based on navigation:

Registrazione.schermo.2026-03-21.alle.17.43.43.mov

@hlolli Possibile issue that we could address (now) are:

  • One mobile view model
  • I do not see the virtual keyboard on mobile, or at least i'm not able to activate it
  • Text editor block renders x number of lines based on live (or stored) text, which is correct but leads on mobile to the container ending above the mobile bar, and the top menu hides the first line ->
Screenshot 2026-03-21 alle 17 51 51

@vlazzarini
Copy link
Member

vlazzarini commented Mar 21, 2026

@Nandos0804 here's a screenshot

rhythm

see the search bar just above the keyboard, obscuring part of the edit window

@Nandos0804
Copy link
Contributor Author

@Nandos0804 here's a screenshot

rhythm

see the search bar just above the keyboard, obscuring part of the edit window

Thank you. It seems a design choice by Apple on iOs 26 ( reference https://forums.macrumors.com/threads/what-is-the-odd-bar-above-keyboard-merged.2465255/ and other reddit post). If this appeared after an update on that device it could be related. I have an old iPhone 6 somewhere, tonight I Will check there.

@vlazzarini
Copy link
Member

ah that explains it. Nothing to see here then, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants