Skip to content

fix(compiler): align contract route conflict validation#291

Merged
cssbruno merged 1 commit into
mainfrom
codex/fix-contract-route-conflict-review
Jun 11, 2026
Merged

fix(compiler): align contract route conflict validation#291
cssbruno merged 1 commit into
mainfrom
codex/fix-contract-route-conflict-review

Conversation

@cssbruno

Copy link
Copy Markdown
Owner

Summary

  • Allow repeated references to the same generated contract route when they match the appgen dedupe identity: kind, method, route, contract, and owner.
  • Use the shared backend route path key for contract route conflict registration after strict path validation succeeds.
  • Add regressions for duplicate identical command/query references and malformed contract paths that must be reported as contract_route_invalid instead of being silently conflict-skipped.

Review Feedback

Addresses Codex review comments on PR #286:

  • Allow duplicate references to the same contract.
  • Validate contract paths with backend normalization semantics.

Verification

  • go test ./internal/compiler ./internal/source
  • go test ./...
  • go build ./cmd/gowdk

LLM Assistance

  • Implemented by Codex from automated review feedback.

@cssbruno cssbruno merged commit 832e3c2 into main Jun 11, 2026
5 checks passed
@cssbruno cssbruno deleted the codex/fix-contract-route-conflict-review branch June 11, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant