Limit photo album visibility

[wilco375]

Fixes issue #383

Summary by CodeRabbit

• New Features

  • Granular visibility levels for photo albums and related content: public, alumni, members.
  • Alumni-visible windows computed from membership dates to surface time-bound content.

• Changes

  • API attribute renamed from a boolean public flag to a visibility field.
  • Authorization now enforces membership and visibility rules more strictly; unauthenticated access limited to truly public items.
  • Database migration to replace boolean flag with visibility values.

• Documentation

  • Permissions documentation updated to reflect visibility-based access.

• Tests

  • Test fixtures, traits and shared contexts updated to cover membership and visibility scenarios.

[lodewiges]

It could be an idea to add a button just like publicly visible for visibility for oudleden. for example, if we have an activity where oudleden are invited. It would also be usefull to look into how this affects the suggestions for phototagging on the SOG page

[wilco375]

It could be an idea to add a button just like publicly visible for visibility for oudleden. for example, if we have an activity where oudleden are invited. It would also be usefull to look into how this affects the suggestions for phototagging on the SOG page

Might be good to add this in addition to comparison of membership date yeah! Then old members can see all photos from their membership and relevant activities from after their membership.

[codecov]

Codecov Report

❌ Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.42%. Comparing base (8743725) to head (c7ae7d8).

Files with missing lines	Patch %	Lines
app/policies/photo_album_policy.rb	25.00%	3 Missing ⚠️
app/policies/photo_comment_policy.rb	0.00%	3 Missing ⚠️
app/policies/photo_policy.rb	0.00%	3 Missing ⚠️
app/models/photo.rb	50.00%	2 Missing ⚠️
app/models/photo_album.rb	60.00%	2 Missing ⚠️
app/resources/v1/photo_album_resource.rb	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           staging     #286      +/-   ##
===========================================
- Coverage    99.92%   96.42%   -3.50%     
===========================================
  Files          197      197              
  Lines         2658     2661       +3     
===========================================
- Hits          2656     2566      -90     
- Misses           2       95      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/limit-photo-visibility

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}