Fix recent photo comments

[wilco375]

Summary

Fixes #874

[lodewiges]

when commenting twice on a photo it shows up twice in recent images. This is unwanted behavior.

[wilco375]

when commenting twice on a photo it shows up twice in recent images. This is unwanted behavior.

Ah that's a good point. This might require some API changes to properly fix then. I'll look into it later!

[DrumsnChocolate]

what an interesting implementation oversight, haha
I trust the resulting implementation after the fix

[DrumsnChocolate]

@wilco375 I don't think you need api changes; is it not possible to compute a list of photos and then run an operation of uniqueness over it? like a set or something like that

[wilco375]

@wilco375 I don't think you need api changes; is it not possible to compute a list of photos and then run an operation of uniqueness over it? like a set or something like that

Not if we want to get a fixed number of photos. Or we'd have to recursively get more photos from the backend until we have enough non-duplicate photos. But that would be nicer and more efficient to solve in a database query.

Either we get the photos directly and sort on date of latest comment => needs API addition of sorting by latest comment
Or we get latest comments but max one comment per picture => needs API addition of custom scope to filter out duplicate images
Or we repeatedly pull images from the API and do the filtering client side as described above, which might be very inefficient, especially if one image has a lot of recent comments (something that might not actually occur in practice but still)

[DrumsnChocolate]

Right. I suppose the sort: '-updated_at', is passed to the API somehow? If that's the case, I suppose we could do some sort: '-commented_at', if we can define some commented_at property in the backend. You're the expert on rails

[DrumsnChocolate]

@wilco375 bump

[wilco375]

@wilco375 bump

Will look at it later. Currently busy with moving to another apartment so don't have much free time

[DrumsnChocolate]

bump again 😉