Bugfix: add better limits on payments & credit mutations#1230
Open
Bugfix: add better limits on payments & credit mutations#1230
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1230 +/- ##
===========================================
+ Coverage 77.61% 77.72% +0.11%
===========================================
Files 54 54
Lines 1407 1414 +7
===========================================
+ Hits 1092 1099 +7
Misses 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
…sofia into Bugfix/limits-payments
Removed test case for too high amount in credit mutation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somebody tried to uplift their saldo with 100,000 euro and this made the request to Mollie fail.
In the past there have been situations where an invoice for €0 was generated which resulted in the same error, and there are situations when the treasurer needs to make credit mutations bigger than €1,000.
All these situations will be addressed with this PR by:
MAX_PAYMENT_AMOUNT)MIN_INVOICE_AMOUNT)Summary by CodeRabbit
Bug Fixes
Improvements
Tests