Remove EnsureBranchPushed function and related code#5
Merged
Conversation
csvenke
force-pushed
the
feature/llm-gh-pr-fix
branch
from
b429cbd to
6211d1d
Compare
- Remove EnsureBranchPushed function from gh package - Remove EnsureBranchPushedFunc variable and its usage from pr command - Remove runGitCommand helper function - Remove all related tests for EnsureBranchPushed
csvenke
force-pushed
the
feature/llm-gh-pr-fix
branch
from
6211d1d to
df3dac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
EnsureBranchPushedfunction and all associated code that handled automatic branch pushing before creating pull requests.Changes
EnsureBranchPushedfunction frominternal/gh/gh.gorunGitCommandhelper function that was only used byEnsureBranchPushedEnsureBranchPushedFuncvariable frominternal/cmd/gh/pr/command.gointernal/cmd/cmd_test.goandinternal/gh/gh_test.goImpact
Pull request creation will no longer automatically push the current branch. Users will need to manually push their branches before creating pull requests.