Auto Canvas Height + Width #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumax315
force-pushed
the
better-canvas-height
branch
2 times, most recently
from
85f18fa to
3fb8834
Compare
dumax315
force-pushed
the
better-canvas-height
branch
from
a83af4e to
cf9abcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done yet, I'm fighting race conditions where the inputs are rendered after the size of the canvas has been decided
I think this needs to be modified to use https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver and overflow:hidden but that is so hacky 😢
as far as i know current version only seems to break on webkit, I'm curious what happens on android and firefox (untested)
Sets the height and width of the animation canvas responsively.
For testing convenience, this branch is hosted at https://vistooldemo.theoh.dev