fix: version deps UI factors in metadata and created_at#1095
fix: version deps UI factors in metadata and created_at#1095adityachoudhari26 merged 1 commit intomainfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 46 minutes and 11 seconds.Comment |
There was a problem hiding this comment.
Pull request overview
Updates the deployment dependency evaluation data flow so the web UI’s CEL-based dependency checks can consider version.createdAt and version.metadata (and related fields) when determining whether a dependency is satisfied.
Changes:
- Extend TRPC dependency query results to include
createdAt,metadata, andmessagefor the currently deployed upstream versions. - Serialize
createdAtto ISO strings in TRPC responses where these versions are returned to the web UI. - Update dependency UI components to pass the newly available fields into the CEL evaluation context.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/trpc/src/routes/release-targets.ts | Adds createdAt, message, metadata, and deploymentId to upstream “current version” dependency payloads for release-target dependencies. |
| packages/trpc/src/routes/deployment-versions.ts | Adds createdAt, message, and metadata to per-(env,resource) dependency “current version” payloads. |
| apps/web/app/routes/ws/deployments/_components/release-targets/Dependencies.tsx | Extends CEL context with createdAt, metadata, message, deploymentId when evaluating dependency satisfaction. |
| apps/web/app/routes/ws/deployments/_components/environmentversiondecisions/rule-results/DependencyDetail.tsx | Extends CEL context with createdAt, metadata, message, deploymentId when evaluating dependency satisfaction per target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| status: version.status, | ||
| deploymentId: version.deploymentId, | ||
| createdAt: version.createdAt, | ||
| message: version.message ?? "", |
| status: version.status, | ||
| deploymentId: version.deploymentId, | ||
| createdAt: version.createdAt, | ||
| message: version.message ?? "", |
No description provided.