Skip to content

chore(deployments): Add link to failed jobs #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsbroks merged 3 commits into from
May 5, 2026
+34 −22
Merged

chore(deployments): Add link to failed jobs #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a74a4cf
Add link to failed jobs
jsingleton-dev May 5, 2026
5db877d
Make link only the name
jsingleton-dev May 5, 2026
6a78067
Add rel
jsingleton-dev May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 33 additions & 21 deletions apps/web/app/routes/ws/deployments/_components/versioncard/VersionCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,27 +234,39 @@ const formatJobStatus = (status: string) => {

const FailedPopoverContent: React.FC<{
targets: ReleaseTargetWithState[];
}> = ({ targets }) => (
<div className="space-y-1.5">
<div className="font-medium">Failed deployments:</div>
{targets.map((rt) => (
<div key={rt.releaseTarget.resourceId} className="text-xs">
<span className="font-medium">{rt.resource.name}</span>
{rt.latestJob?.status && (
<span className="text-muted-foreground">
{" "}
— {formatJobStatus(rt.latestJob.status)}
</span>
)}
{rt.latestJob?.message && (
<div className="mt-0.5 text-muted-foreground">
{rt.latestJob.message}
</div>
)}
</div>
))}
</div>
);
}> = ({ targets }) => {
const { workspace } = useWorkspace();
const { deployment } = useDeployment();
return (
<div className="space-y-1.5">
<div className="font-medium">Failed deployments:</div>
{targets.map((rt) => (
<div key={rt.releaseTarget.resourceId} className="text-xs">
<Link
to={`/${workspace.slug}/deployments/${deployment.id}/release-targets?query=${encodeURIComponent(rt.resource.name)}`}
target="_blank"
rel="noopener noreferrer"
className="font-medium hover:underline"
onClick={(e) => e.stopPropagation()}
>
{rt.resource.name}
</Link>
{rt.latestJob?.status && (
<span className="text-muted-foreground">
{" "}
— {formatJobStatus(rt.latestJob.status)}
</span>
)}
{rt.latestJob?.message && (
<div className="mt-0.5 text-muted-foreground">
{rt.latestJob.message}
</div>
)}
</div>
))}
</div>
);
};

const DeploymentIssues: React.FC<{
pending: number;
Expand Down
2 changes: 1 addition & 1 deletion apps/web/app/routes/ws/deployments/page.$deploymentId.release-targets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { EnvironmentReleaseTargetsGroup } from "./_components/release-targets/En

function useResource() {
const [searchParams, setSearchParams] = useSearchParams();
const query = searchParams.get("resource") ?? "";
Copy link
Copy Markdown
Collaborator Author

@jsingleton-dev jsingleton-dev May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing an existing bug. The code was reading from resource but writing to the query param

const query = searchParams.get("query") ?? "";
const [search, setSearch] = useState(query);
const [searchDebounced, setSearchDebounced] = useState(search);
useDebounce(
Expand Down
Loading