Fix #130 and #114 -- removing tabs error#131
Open
stefanuros wants to merge 1 commit intoctxhou:masterfrom
Open
Fix #130 and #114 -- removing tabs error#131stefanuros wants to merge 1 commit intoctxhou:masterfrom
stefanuros wants to merge 1 commit intoctxhou:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 87.27% 86.82% -0.45%
==========================================
Files 20 20
Lines 330 334 +4
Branches 63 65 +2
==========================================
+ Hits 288 290 +2
- Misses 34 36 +2
Partials 8 8
Continue to review full report at Codecov.
|
Owner
|
Hey @stefanuros! Thanks for the contribution! |
|
Since it's been almost a year, seems like this isn't going to be updated. Can we merge the change in without the test case? |
|
Looks like @stefanuros had abandoned it. I tried to create some tests here but no success yet. Someone had progress? @anjalikk14 did you accomplished something? Could you (@ctxhou) give me some clue in how to approach it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #130 and #114 as they stem from the same issue of index checking elements that are out of bounds. This fix will prevent crashes when closing tabs and modals.