Skip to content

fix(cubesql): Do not panic when executing MEASURE function#10472

Merged
MazterQyou merged 1 commit intomasterfrom
cubesql/measure-no-panic
Mar 6, 2026
Merged

fix(cubesql): Do not panic when executing MEASURE function#10472
MazterQyou merged 1 commit intomasterfrom
cubesql/measure-no-panic

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Mar 6, 2026

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR changes the behavior of MEASURE function to return a helpful error instead of panicking when it is being executed due to unsupported plan. Related test is included.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested a review from a team as a code owner March 6, 2026 09:21
@github-actions github-actions bot added the rust Pull requests that update Rust code label Mar 6, 2026
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.52%. Comparing base (49e9aec) to head (515c803).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10472      +/-   ##
==========================================
- Coverage   78.52%   78.52%   -0.01%     
==========================================
  Files         472      472              
  Lines       92294    92313      +19     
  Branches     3563     3563              
==========================================
+ Hits        72474    72488      +14     
- Misses      19282    19287       +5     
  Partials      538      538              
Flag Coverage Δ
cube-backend 57.65% <ø> (ø)
cubesql 83.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 3202d51 into master Mar 6, 2026
124 of 125 checks passed
@MazterQyou MazterQyou deleted the cubesql/measure-no-panic branch March 6, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants