fix(cube): Issue with rollup pre-aggragations matching for views#10474
Merged
waralexrom merged 4 commits intomasterfrom Mar 6, 2026
Merged
fix(cube): Issue with rollup pre-aggragations matching for views#10474waralexrom merged 4 commits intomasterfrom
waralexrom merged 4 commits intomasterfrom
Conversation
ovr
reviewed
Mar 6, 2026
Member
ovr
left a comment
There was a problem hiding this comment.
Looks good overall, left a couple of suggestions for test coverage.
...ubejs-schema-compiler/test/integration/postgres/pre-aggregations-calculated-measures.test.ts
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10474 +/- ##
===========================================
- Coverage 78.52% 57.65% -20.88%
===========================================
Files 472 222 -250
Lines 92294 17397 -74897
Branches 3563 3562 -1
===========================================
- Hits 72474 10030 -62444
+ Misses 19282 6829 -12453
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List