Skip to content

fix(cube): Issue with rollup pre-aggragations matching for views#10474

Merged
waralexrom merged 4 commits intomasterfrom
cube-fix-rollup-join-matching
Mar 6, 2026
Merged

fix(cube): Issue with rollup pre-aggragations matching for views#10474
waralexrom merged 4 commits intomasterfrom
cube-fix-rollup-join-matching

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested a review from a team as a code owner March 6, 2026 16:52
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Mar 6, 2026
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a couple of suggestions for test coverage.

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🎉

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.65%. Comparing base (49e9aec) to head (815c1c7).
⚠️ Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (49e9aec) and HEAD (815c1c7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (49e9aec) HEAD (815c1c7)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10474       +/-   ##
===========================================
- Coverage   78.52%   57.65%   -20.88%     
===========================================
  Files         472      222      -250     
  Lines       92294    17397    -74897     
  Branches     3563     3562        -1     
===========================================
- Hits        72474    10030    -62444     
+ Misses      19282     6829    -12453     
  Partials      538      538               
Flag Coverage Δ
cube-backend 57.65% <100.00%> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@waralexrom waralexrom merged commit 7160283 into master Mar 6, 2026
109 of 110 checks passed
@waralexrom waralexrom deleted the cube-fix-rollup-join-matching branch March 6, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants