-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Links in the data model #10852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paveltiunov
wants to merge
19
commits into
master
Choose a base branch
from
cursor/feat-links-documentation-638d
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6c3fcde
feat: add links, html, and synthetic dimension parameters documentation
cursoragent e97d76a
fix: remove html section, implement only links per request
cursoragent b403976
feat: implement links feature in schema compiler and API gateway
cursoragent 779d1e8
refactor: treat link url as standard SQL expression, not a template
cursoragent ac4dafa
feat: add Tesseract (native SQL planner) support for links
cursoragent ec31cae
refactor: implement links as synthetic dimensions instead of flag-bas…
cursoragent 6330769
feat: add name property to links, use it in synthetic dimension naming
cursoragent 0b09261
feat: auto-include synthetic link dimensions when member is included …
cursoragent 8405f07
refactor: generate synthetic link dims after include/exclude logic
cursoragent dd73d3b
feat: implement links feature for dimensions in the data model
cursoragent 8df11cf
fix: handle link.name as function (YAML compiler wraps strings as tem…
cursoragent f834198
fix: mutate dimensions object in place instead of reassigning
cursoragent 093b684
fix: use SQL || concatenation in test instead of CONCAT()
cursoragent f153226
fix: simplify test URL expressions to avoid Python parser issues
cursoragent cefc527
fix: correct test assertion - link name is send_email not email
cursoragent 4377e5f
fix: correct test assertions for link names and simplify validation test
cursoragent 5d15a9a
fix: replace SQL generation test with dimension existence check
cursoragent 9c97103
feat: make link dimensions public, validate name as identifier, add a…
cursoragent fa6fc33
fix: add non-null assertions for strict TS checks in test
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Ambiguous heading. The
#### Dimensionsheading is used as a sub-section under bothlinksandhtmlto describe the synthetic dimensions generated in the result set. Since this appears inside a page titled "Dimensions," the heading reads like a circular reference. Consider a more descriptive title like#### Generated dimensionsor#### Synthetic dimensions in the result setto make it immediately clear what this sub-section covers.