Enforce rechunking for sharded Icechunk store#897
Open
claxn wants to merge 2 commits intocubed-dev:mainfrom
Open
Enforce rechunking for sharded Icechunk store#897claxn wants to merge 2 commits intocubed-dev:mainfrom
claxn wants to merge 2 commits intocubed-dev:mainfrom
Conversation
Member
That would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #896 by enforcing a rechunking of the input array, if the output store is sharded and the input chunks do not match the shards.
Should we add a warning to notify the users that there is a mismatch of
cubedchunks and Zarrshards?