Use a simple newtype wrapper to simplify literal bookkeeping in parsers#1
Merged
Conversation
To make the common logic between the ASCII and binary parsers a little more obvious/readable, I have tried to wrap the `HashMap` for keeping track of AIGER literals in a little utility. In general, this kind of thing (where we make a special newtype struct and add methods on it) can be a nice way to organize code so it's obvious what a given data structure is "meant to be used for."
Previously, the hash table here would sometimes contain negated literals and sometimes not. Now, we always avoid storing the negated literal; `add`ing either the positive or negative version of a literal suffices to create a mapping for both. This entails a bit more work on the insertion side, but it makes the lookup side simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to simplify some of the handling of AIGER literals when doing the parsing.
@Modertool999, please take a look at the commit messages for both of the commits below and let me know what you think!