Handle header fields (only) for AIGER 1.9 extensions#5
Open
sampsyo wants to merge 3 commits into
Open
Conversation
Previously, we would parse the first 5 numbers from the header, and then silently ignore any other data found there. This made it confusing to find the problem when trying to parse an "extended AIGER" file that has more header fields. This way, we crash noisily when there is unknown data there---which seems a little more future-proof.
Just introduce a function to make this code a little less repetitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIGER 1.9 files add a few extensions on top of the original version. This adds support for handling the extra fields in the header only and panics if any of the relevant counts are nonzero. This maintains backward-compatibility while setting us up to someday handle those extra components.
The (sole?) document describing the AIGER 1.9 extensions is, however, sadly lacking in detail. Exactly where in the file do each of the new "B C J F" lines appear? What precisely are each of these lines (or binary-encoded values) allowed to contain? The document doesn't make it clear. I think we'll have to look at the C project's source code, or possibly the relevant support in CIRCT, to figure out exactly what to parse.