Fix Errno::EACCES errors in tempfile finalizer on Windows#992
Open
mvz wants to merge 9 commits into
Open
Conversation
mvz
changed the title
mvz
force-pushed
the
fix-tempfile-eaccess
branch
from
7c4eec5 to
4a81078
Compare
Status on Unix is only set if the program had a chance to call exit().
This reverts commit d3412f3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TBD
Details
TBD
Motivation and Context
The build logs on Windows are filled with errors raised the finalizers of the tempfiles we use to capture the output of processes in
SpawnProcess.This may be a genuine problem preventing Aruba from working properly on Windows: It possibly causes or is related to the Aruba scratch directory not getting cleaned up.
How Has This Been Tested?
Unfortunately, we once again have to test this in CI.
Types of changes
Checklist: