Skip to content

V11 - Event Migration to Envelopes -> GherkinSourceRead#1877

Merged
luke-hill merged 2 commits into
feature/v11_message_emittence_at_sourcefrom
feature/v11/gherkin_source_read
May 26, 2026
Merged

V11 - Event Migration to Envelopes -> GherkinSourceRead#1877
luke-hill merged 2 commits into
feature/v11_message_emittence_at_sourcefrom
feature/v11/gherkin_source_read

Conversation

@luke-hill
Copy link
Copy Markdown
Contributor

Description

This is the first of many PR's that will aim to migrate out the complexity of MessageBuilder so that the raw events being emitted are that of Envelope's with the requisite info.

As such this will remove the need to emit events and then convert them.

This will see us create a series of #to_envelope methods in the requisite places here or in core

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • New feature (non-breaking change which adds new behaviour)

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill luke-hill changed the base branch from main to feature/v11_message_emittence_at_source May 22, 2026 21:35
@luke-hill luke-hill force-pushed the feature/v11/gherkin_source_read branch from 2400bc1 to d809fc2 Compare May 22, 2026 22:23
@luke-hill
Copy link
Copy Markdown
Contributor Author

ping @brasmusson

@luke-hill luke-hill merged commit 45190e7 into feature/v11_message_emittence_at_source May 26, 2026
@luke-hill luke-hill deleted the feature/v11/gherkin_source_read branch May 26, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant