V11 - Message Emittence from direct source#1879
Open
luke-hill wants to merge 9 commits into
Open
Conversation
* Add envelope generation at source for gherkin_source_read event * Do not double fire events
…kFinished (#1878) * Add in logic for both run hook events to be passed as messages * Store test_run_started_id cache on config class instance * Pass in the test_run_started_id on hook_run_started message generation and remove faux update from envelope emittence
…_source' into feature/v11_message_emittence_at_source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This epic PR will move as many / all of the message emittence events to the direct source of truth. i.e. from where
@configuration.notifyis called.Most of these should be easy to do, a few may require some additional bits of work
Type of change
Please delete options that are not relevant.
NB: A single Changelog message will be written here once all are done
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses